fix: 204 is an acceptable response to DELETEing the session#697
Merged
ihrpr merged 1 commit intomodelcontextprotocol:mainfrom May 12, 2025
Merged
Conversation
Contributor
Author
|
No problem, thanks for the quick merge @ihrpr! |
maxisbey
added a commit
that referenced
this pull request
Mar 26, 2026
RFC 6570 requires repeated variables to expand to the same value. Enforcing this at match time would require backreferences with potentially exponential cost. We reject at parse time instead, following the recommendation in #697. Previously a template like {x}/{x} would parse and silently return only the last captured value on match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #696
Motivation and Context
204 is the correct response code to return for a body-less response, per RFC 7231.
How Has This Been Tested?
Breaking Changes
None
Types of changes
Checklist