Skip to content

ci: remove claude-code-review workflow#2359

Merged
maxisbey merged 1 commit intomainfrom
ci/remove-claude-code-review-workflow
Mar 27, 2026
Merged

ci: remove claude-code-review workflow#2359
maxisbey merged 1 commit intomainfrom
ci/remove-claude-code-review-workflow

Conversation

@maxisbey
Copy link
Copy Markdown
Contributor

Removes the automated code review workflow that ran on every PR push.

Motivation and Context

CCR now handles code review on this repo (since ~2026-03-08), making this workflow redundant. Worse, the workflow has pull-requests: read permissions so it cannot actually post reviews — it's been running on every push (19 times on #2356 alone) and producing no visible output.

The claude.yml workflow for @claude mentions is retained. #2337 already added the @claude review exclusion guard so it doesn't overlap with CCR.

Matches modelcontextprotocol/typescript-sdk#1754.

How Has This Been Tested?

Workflow-only change; no code impact. Verified CCR is active by checking recent PRs (#2345, #2356, #2358) — all show the claude app check-suite posting reviews with inline comments and "Extended reasoning" summaries.

Breaking Changes

None.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

v1.x never had this workflow, so no backport needed.

AI Disclaimer

CCR now handles code review on this repo (since ~2026-03-08), making
this workflow redundant. The workflow has been running on every PR push
but cannot post reviews due to read-only pull-requests permissions, so
it was consuming compute without producing visible output.

The claude.yml workflow for @claude mentions is retained. #2337 already
added the '@claude review' exclusion guard so it does not overlap with
CCR.

Matches typescript-sdk#1754.
@maxisbey maxisbey enabled auto-merge (squash) March 27, 2026 13:59
Copy link
Copy Markdown
Contributor

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward removal of a redundant CI workflow.

Extended reasoning...

Overview

This PR deletes a single file: .github/workflows/claude-code-review.yml. The workflow was an automated code review action that triggered on every PR push. It has been superseded by CCR (Claude Code Review) which is now active on the repo, making this workflow redundant. The PR description notes the workflow also had insufficient permissions (pull-requests: read instead of write) so it was running without producing visible output.

Security risks

None. This is a pure deletion of a CI workflow file. No application code, dependencies, or permissions are modified. Removing the workflow actually eliminates unnecessary CI runs and an unused OIDC token grant.

Level of scrutiny

Minimal scrutiny is appropriate. This is a single-file deletion of a CI config with no impact on application code or tests. The motivation is well-documented and the change mirrors an equivalent PR in the TypeScript SDK.

Other factors

No bugs were found. No outstanding reviewer comments. The change is self-contained and clearly correct — removing a workflow that was both redundant and non-functional.

Copy link
Copy Markdown
Contributor

@felixweinberger felixweinberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@maxisbey maxisbey merged commit fb2276b into main Mar 27, 2026
31 checks passed
@maxisbey maxisbey deleted the ci/remove-claude-code-review-workflow branch March 27, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants