nes: fix: don't error if server response contained no choices#4439
Merged
nes: fix: don't error if server response contained no choices#4439
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Next Edit Suggestions (NES) error handling in XtabProvider so that “diff-patch” models returning a response with no choices (i.e., no edits) is treated as “no suggestions” rather than surfacing as a fetch failure.
Changes:
- Detects
ChatFetchResponseType.Unknownresponses with reason containing"Response contained no choices." - Returns
NoNextEditReason.NoSuggestionsfor that case instead of mapping to a fetch failure
chrmarti
previously approved these changes
Mar 17, 2026
diff-patch models return no choices if they have no edits
2e4d077 to
4a437d7
Compare
sandy081
approved these changes
Mar 17, 2026
ulugbekna
added a commit
that referenced
this pull request
Mar 17, 2026
diff-patch models return no choices if they have no edits
ulugbekna
added a commit
that referenced
this pull request
Mar 17, 2026
diff-patch models return no choices if they have no edits
ulugbekna
added a commit
that referenced
this pull request
Mar 17, 2026
diff-patch models return no choices if they have no edits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diff-patch models return no choices if they have no edits