nes: patch-based: test: ensure trailing newline is no issue#4427
Merged
nes: patch-based: test: ensure trailing newline is no issue#4427
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a regression test to ensure XtabCustomDiffPatchResponseHandler.extractEdits() can parse patch input that ends with a trailing newline (common when streaming/assembling text).
Changes:
- Added a new unit test covering patch parsing with a trailing newline.
- Updated expectations to compare parsed output against a normalized version of the input.
bpasero
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.