Auto approve reading files from original repo when using worktrees#4280
Merged
DonJayamanne merged 4 commits intomainfrom Mar 8, 2026
Merged
Auto approve reading files from original repo when using worktrees#4280DonJayamanne merged 4 commits intomainfrom
DonJayamanne merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to auto-approve read permission requests for files that belong to the “session workspace” when a Copilot CLI session is using a git worktree as its working directory—so reads from the original repository don’t unnecessarily prompt the user.
Changes:
- Updated Copilot CLI session logic to use
this.workspaceconsistently when deriving working directory. - Added a helper to decide whether a requested read path is within the session workspace (working directory / folder / repo-worktree context).
- Added unit tests covering read auto-approval behavior for worktree-related workspace shapes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/extension/chatSessions/copilotcli/node/copilotcliSession.ts | Refactors working directory lookups and introduces session-workspace read auto-approval helper. |
| src/extension/chatSessions/copilotcli/node/test/copilotcliSession.spec.ts | Adds tests validating read auto-approval when worktrees are present. |
src/extension/chatSessions/copilotcli/node/test/copilotcliSession.spec.ts
Show resolved
Hide resolved
src/extension/chatSessions/copilotcli/node/copilotcliSession.ts
Outdated
Show resolved
Hide resolved
src/extension/chatSessions/copilotcli/node/copilotcliSession.ts
Outdated
Show resolved
Hide resolved
src/extension/chatSessions/copilotcli/node/copilotcliSession.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bpasero
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.