Skip to content

exp: set exp header if snippy is in blocking mode#4032

Merged
ulugbekna merged 2 commits intomainfrom
ulugbekna/nasty-swan
Feb 26, 2026
Merged

exp: set exp header if snippy is in blocking mode#4032
ulugbekna merged 2 commits intomainfrom
ulugbekna/nasty-swan

Conversation

@ulugbekna
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings February 26, 2026 10:34
@ulugbekna ulugbekna enabled auto-merge February 26, 2026 10:34
@ulugbekna ulugbekna self-assigned this Feb 26, 2026
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 26, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for an sn (Snippy blocking mode) flag from the Copilot token into the experimentation user info cache and ExP filter headers, enabling experiment targeting based on Snippy’s blocking state.

Changes:

  • Parse sn=1 from the Copilot token (CopilotToken.isSn()).
  • Persist isSn in UserInfoStore and include it in GitHub account ExP filter headers (X-GitHub-Copilot-IsSn).
  • Add unit tests validating isSn detection and caching behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/platform/telemetry/vscode-node/microsoftExperimentationService.ts Adds X-GitHub-Copilot-IsSn filter and logs isSn alongside other user filters.
src/platform/telemetry/test/node/experimentation.spec.ts Adds tests for sn flag detection and persistence via UserInfoStore/globalState.
src/platform/telemetry/node/baseExperimentationService.ts Extends UserInfoStore to track/persist isSn and treat it as part of change detection.
src/platform/authentication/common/copilotToken.ts Adds isSn() token flag accessor based on sn=1.

@ulugbekna ulugbekna added this pull request to the merge queue Feb 26, 2026
Merged via the queue into main with commit 5b3d816 Feb 26, 2026
19 checks passed
@ulugbekna ulugbekna deleted the ulugbekna/nasty-swan branch February 26, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants