fix(cli): do not fall through open/attach args into session#40176
Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom Apr 13, 2026
Merged
fix(cli): do not fall through open/attach args into session#40176pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman merged 1 commit intomicrosoft:mainfrom
Conversation
dgozman
approved these changes
Apr 12, 2026
| ownership = 'own'; | ||
| } else if (config.extension) { | ||
| browser = await createExtensionBrowser(config, clientInfo.clientName); | ||
| ownership = 'own'; |
Collaborator
There was a problem hiding this comment.
'attached'? Or perhaps 'extension' to show (extension) in the list?
This comment has been minimized.
This comment has been minimized.
yury-s
approved these changes
Apr 12, 2026
yury-s
approved these changes
Apr 12, 2026
ae459a7 to
c36a357
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
c36a357 to
3d2cdb8
Compare
Contributor
Test results for "tests 1"1 failed 5 flaky39154 passed, 846 skipped Merge workflow run. |
Contributor
Test results for "MCP"6521 passed, 382 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary