fix: rust-string_cache0.8: fix upstream-name to match component name#16476
fix: rust-string_cache0.8: fix upstream-name to match component name#16476binujp wants to merge 1 commit intotomls/base/mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the component definition for rust-string_cache0.8 to adjust how the upstream Fedora spec source is resolved/pinned, aiming to ensure the correct upstream package/commit is used for Azure Linux’s Fedora 43 import flow.
Changes:
- Update
spec.upstream-nameforrust-string_cache0.8. - Update the pinned
spec.upstream-commitfor the Fedora 43 source.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # TODO: Drop this override once the default Fedora 43 snapshot | ||
| # in distro/azurelinux.distro.toml advances past this commit. | ||
| spec = { type = "upstream", upstream-name = "rust-string_cache", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "0823d01a166f380d91468ed92c16bc57ad04398b" } | ||
| spec = { type = "upstream", upstream-name = "rust-string_cache0.8", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "2e6bd9ce90358f9525bb4421ee361d8e641edbe3" } |
There was a problem hiding this comment.
This change updates upstream-commit in addition to upstream-name, but the PR title/summary only mentions the upstream-name fix. Please document why the pinned commit is changing and how the new commit was selected (e.g., the Fedora 43 build commit it corresponds to), so reviewers can validate the pin is still correct.
| @@ -2,4 +2,4 @@ | |||
| # Pin to the f43 commit used to build the current Fedora 43 package. | |||
There was a problem hiding this comment.
This pin uses upstream-commit, but there’s no reference link to the upstream/Fedora dist-git commit being pinned. Per repo guidance, please add a full URL (e.g., src.fedoraproject.org/rpms//c/) alongside the existing TODO so future maintainers can quickly verify and drop the pin when the distro snapshot advances.
| # Pin to the f43 commit used to build the current Fedora 43 package. | |
| # Pin to the f43 commit used to build the current Fedora 43 package. | |
| # Fedora dist-git commit: https://src.fedoraproject.org/rpms/rust-string_cache0.8/c/2e6bd9ce90358f9525bb4421ee361d8e641edbe3 |
rust-string_cache0.8: fix upstream-name to match component name
Verified with koji build:
koji/taskinfo?taskID=1128233
closed buildSRPMFromSCM (/microsoft/azurelinux.git:3d5ac0e390d3fde1129304412a3bd89bee93de31)
closed buildArch (rust-string_cache0.8-0.8.9-1.azl4
bootstrap.20260405.src.rpm, x86_64)bootstrap.20260405.src.rpm, aarch64)closed buildArch (rust-string_cache0.8-0.8.9-1.azl4
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology