Skip to content

fix: rust-string_cache0.8: fix upstream-name to match component name#16476

Open
binujp wants to merge 1 commit intotomls/base/mainfrom
bphilip/rust-string_cache0.8
Open

fix: rust-string_cache0.8: fix upstream-name to match component name#16476
binujp wants to merge 1 commit intotomls/base/mainfrom
bphilip/rust-string_cache0.8

Conversation

@binujp
Copy link
Copy Markdown
Contributor

@binujp binujp commented Apr 6, 2026

rust-string_cache0.8: fix upstream-name to match component name

Verified with koji build:

koji/taskinfo?taskID=1128233
closed buildSRPMFromSCM (/microsoft/azurelinux.git:3d5ac0e390d3fde1129304412a3bd89bee93de31)
closed buildArch (rust-string_cache0.8-0.8.9-1.azl4bootstrap.20260405.src.rpm, x86_64)
closed buildArch (rust-string_cache0.8-0.8.9-1.azl4
bootstrap.20260405.src.rpm, aarch64)

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
  • Change
  • Change
  • Change
Does this affect the toolchain?

YES/NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

Copilot AI review requested due to automatic review settings April 6, 2026 23:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the component definition for rust-string_cache0.8 to adjust how the upstream Fedora spec source is resolved/pinned, aiming to ensure the correct upstream package/commit is used for Azure Linux’s Fedora 43 import flow.

Changes:

  • Update spec.upstream-name for rust-string_cache0.8.
  • Update the pinned spec.upstream-commit for the Fedora 43 source.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# TODO: Drop this override once the default Fedora 43 snapshot
# in distro/azurelinux.distro.toml advances past this commit.
spec = { type = "upstream", upstream-name = "rust-string_cache", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "0823d01a166f380d91468ed92c16bc57ad04398b" }
spec = { type = "upstream", upstream-name = "rust-string_cache0.8", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "2e6bd9ce90358f9525bb4421ee361d8e641edbe3" }
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change updates upstream-commit in addition to upstream-name, but the PR title/summary only mentions the upstream-name fix. Please document why the pinned commit is changing and how the new commit was selected (e.g., the Fedora 43 build commit it corresponds to), so reviewers can validate the pin is still correct.

Copilot uses AI. Check for mistakes.
@@ -2,4 +2,4 @@
# Pin to the f43 commit used to build the current Fedora 43 package.
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pin uses upstream-commit, but there’s no reference link to the upstream/Fedora dist-git commit being pinned. Per repo guidance, please add a full URL (e.g., src.fedoraproject.org/rpms//c/) alongside the existing TODO so future maintainers can quickly verify and drop the pin when the distro snapshot advances.

Suggested change
# Pin to the f43 commit used to build the current Fedora 43 package.
# Pin to the f43 commit used to build the current Fedora 43 package.
# Fedora dist-git commit: https://src.fedoraproject.org/rpms/rust-string_cache0.8/c/2e6bd9ce90358f9525bb4421ee361d8e641edbe3

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants