Recognize export * as default as a syntactic default export for synthetic default detection#55985
Recognize export * as default as a syntactic default export for synthetic default detection#55985andrewbranch merged 2 commits intomainfrom
export * as default as a syntactic default export for synthetic default detection#55985Conversation
…thetic default detection
| return ((isExportAssignment(node) && !node.isExportEquals) | ||
| || hasSyntacticModifier(node, ModifierFlags.Default) | ||
| || isExportSpecifier(node) | ||
| || isNamespaceExport(node)); |
There was a problem hiding this comment.
Is the following covered under these rules?
import * as yadda from "./yadda";
export { yadda as default };There was a problem hiding this comment.
Yes (isExportSpecifier)
There was a problem hiding this comment.
This function is only called when the symbol attached to the declaration was reached by the name default, which is why these don’t check specifically check for defaultness.
There was a problem hiding this comment.
It’s intended to distinguish between these ES module syntaxes and something like
export = {
options: {},
default: {},
}|
@typescript-bot test top200 |
|
Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at d3ebc25. You can monitor the build here. Update: The results are in! |
|
@DanielRosenwasser Here are the results of running the top-repos suite comparing Everything looks good! |
robpalme
left a comment
There was a problem hiding this comment.
LGTM - thank you for the quick fix!
Fixes #55829