fix(55945): Inlay hints don't work for bigint literals#55947
Merged
MariaSolOs merged 9 commits intomicrosoft:mainfrom Oct 4, 2023
Merged
fix(55945): Inlay hints don't work for bigint literals#55947MariaSolOs merged 9 commits intomicrosoft:mainfrom
MariaSolOs merged 9 commits intomicrosoft:mainfrom
Conversation
DanielRosenwasser
approved these changes
Oct 2, 2023
Contributor
|
I would prefer adding an extra check before the switch to handle literal nodes: if (tokenString) {
parts.push({ text: tokenString });
return;
}
if (isLiteralExpression(node)) { // New check
parts.push({ text: node.text });
return;
}
switch (node.kind) { ...We can then remove these cases: TypeScript/src/services/inlayHints.ts Lines 489 to 494 in c66d0dc |
MariaSolOs
approved these changes
Oct 2, 2023
DanielRosenwasser
requested changes
Oct 2, 2023
MariaSolOs
reviewed
Oct 3, 2023
MariaSolOs
approved these changes
Oct 4, 2023
Contributor
|
LGTM! I'll merge this now since you've addressed @DanielRosenwasser's (and my) suggestions. Thanks again for the fix @a-tarasyuk (and your patience 😅) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55945