Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on code quality improvements and modernization across CCF service header files, including explicit enum sizing, literal correctness, and modern C++ idioms.
- Adds explicit
uint8_tunderlying type to all service-related enums for consistent size guarantees - Improves literal type safety and constructor parameter handling
- Extends clang-tidy coverage to service headers
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| include/ccf/service/tables/service.h | Add uint8_t underlying type to ServiceStatus enum |
| include/ccf/service/tables/proposals.h | Add uint8_t underlying type to ProposalState enum |
| include/ccf/service/tables/members.h | Add uint8_t to enums, modernize NewMember constructor with std::move and pass-by-value |
| include/ccf/service/tables/jwt.h | Add uint8_t underlying type to JwtIssuerKeyFilter enum |
| include/ccf/service/tables/jsengine.h | Add ULL/U literal suffixes to constexpr numeric constants |
| include/ccf/service/tables/gov.h | Add default initializer to state field, remove redundant else branch in formatter |
| include/ccf/service/reconfiguration_type.h | Add uint8_t underlying type to ReconfigurationType enum |
| include/ccf/service/node_info_network.h | Add uint8_t to enums, replace size() > 0 with empty() check |
| include/ccf/service/node_info.h | Add uint8_t underlying type to NodeStatus enum |
| include/ccf/service/consensus_type.h | Add uint8_t underlying type to ConsensusType enum |
| include/ccf/service/code_status.h | Add uint8_t underlying type to CodeStatus enum |
| include/ccf/service/blit_serialiser_pem.h | Modernize return statements with brace initialization |
| include/ccf/ds/json.h | Add explicit noexcept copy constructor to JsonParseError |
| .clang-tidy | Extend HeaderFilterRegex to cover service and threading directories |
cjen1-msft
reviewed
Nov 10, 2025
cjen1-msft
approved these changes
Nov 10, 2025
Merged
This was referenced Mar 19, 2026
achamayou
added a commit
that referenced
this pull request
Mar 19, 2026
) (#7752) Co-authored-by: Eddy Ashton <ashton.eddy@gmail.com> Co-authored-by: Amaury Chamayou <amaury@xargs.fr> Co-authored-by: Amaury Chamayou <amchamay@microsoft.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7444