DataModule refactoring following #758#768
Merged
FilippoOlivo merged 8 commits intomathLab:0.3-datafrom Mar 18, 2026
Merged
Conversation
Member
Author
|
Hi, the structure of this PR is ready. Still missing tests update and docs. @dario-coscia @ndem0, please give me a feedback. |
4ab95b7 to
47ec090
Compare
Collaborator
|
@FilippoOlivo, is this still to fix or in review? Change the label when you want the review |
Member
Author
The structure is solid. I’ll focus on fixing the tests and documentation next. In the meantime, I’d appreciate any feedback on the overall code architecture. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #766
Checklist