Added short and long form for month.#8
Added short and long form for month.#8heymartinadams wants to merge 1 commit intomasterfrom unknown repository
Conversation
|
Hey, thanks~! I would not – sorry 😞 I'll get around to adding in #7 in the near-ish future which will allow you to do whatever you want. It's been on my todo list... will try to fast track it this week. By the way, it's generally a good idea to open an issue first to discuss new features so that you don't risk spending time on something that doesn't land. I appreciate the effort & time you do put into it, but it makes me feel guilty for the same reason. Also, I'd recommend not changing a project's code style. It hurts your chances at getting merged. Feature aside, I would have rejected/requested that you revert those changes – Thank you & sorry again~! Cheers |
|
That totally makes sense, thanks, @lukeed. I’ll open an issue first, next time. Also, thanks for explaining why you use ES5. And, yes, will keep code style as-is, next time I issue a PR. Not a problem, thanks for considering. Ciao |
|
Cool, thank you for your understanding :) Custom dictionaries are now available under v1.2.0~! I used your examples here as the illustrative example. Thanks again 🙌 |
Great package! Awesome that it’s so small. Not sure if you’d like to add short and long form for month, @lukeed. Increased size from 340B to to 366B.