Skip to content

Improve GRIView layout and axis label positioning in GRIRiskGridView#584

Merged
marionbarker merged 2 commits intodevfrom
gri-chart
Mar 30, 2026
Merged

Improve GRIView layout and axis label positioning in GRIRiskGridView#584
marionbarker merged 2 commits intodevfrom
gri-chart

Conversation

@codebymini
Copy link
Copy Markdown
Collaborator

Summary

  • Update the GRI chart layout so the hyperglycemia label is shown alongside the y-axis
  • Align the hypoglycemia label under the plotted chart area
  • Make the plotted point mapping explicit so hypo is used for x and hyper for y

Copy link
Copy Markdown
Contributor

@bjorkert bjorkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve by code review and test. Significant improvement in labeling.

@marionbarker marionbarker merged commit ca395aa into dev Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants