fix(mobile): JMD currency precision in price conversion and transaction display#606
Closed
Gengyscan wants to merge 1 commit intolnflash:mainfrom
Closed
fix(mobile): JMD currency precision in price conversion and transaction display#606Gengyscan wants to merge 1 commit intolnflash:mainfrom
Gengyscan wants to merge 1 commit intolnflash:mainfrom
Conversation
Send/Receive rounding: - use-price-conversion.ts: Math.round for all currencies, not BTC-only - payment-request.ts: Math.round before lnUsdInvoiceCreate - intraledger.ts: Math.round before intraLedgerUsdPaymentSend Transaction display: - TxItem.tsx: use settlementDisplayAmount/Currency from API instead of manual conversion - transactions.ts: Breez payments convert to user DisplayCurrency, not hardcoded USD Amount inflation fix (settlementAmount is already in cents): - transaction-filters.ts: remove erroneous * 100 in convertToDisplayCurrency and orderAndConvertTransactionsByDate - reconciliation.tsx: remove erroneous * 100 in balance calculation Ref: lnflash/flash#282
bb86992 to
30f28b9
Compare
Author
|
Hi, checking in on this JMD precision fix for mobile. Let me know if anything needs adjusting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary