Make HTML transformation dependencies optional#190
Merged
Conversation
pip install emails - lightweight, only message building and sending
pip install emails[html] - full install with HTML transformer (lxml, cssutils,
premailer, chardet, requests)
Move heavy dependencies (lxml, cssutils, premailer, chardet, requests) from
install_requires to extras_require['html']. Make requests import lazy in
utils.py so that `import emails` works without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install_requirestoextras_require['html']requestsimport lazy inutils.pysoimport emailsworks without itpip install emails) only requirespython-dateutilpip install emails[html]Supersedes #189.