Fix incorrect isinstance check in parse_name_and_email_list#176
Merged
Conversation
19ac7a2 to
8d72705
Compare
The condition on line 134 was checking `isinstance(e, string_types)` twice instead of checking `n` in the second test. This caused the name type validation to be silently skipped. Fixes #167
8d72705 to
f1e81eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
emails/utils.py:isinstance(e, string_types)was checked twice instead of checkingnin the second test, causing the name type validation to be silently skipped.Fixes #167