Switch image in gRPC probe tests to agnhost #115800
Switch image in gRPC probe tests to agnhost #115800k8s-ci-robot merged 3 commits intokubernetes:masterfrom
Conversation
Signed-off-by: Shogo Hida <shogo.hida@gmail.com>
|
Welcome @shogohida! |
|
Hi @shogohida. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| Image: imageutils.GetE2EImage(imageutils.Agnhost), | ||
| Command: []string{ | ||
| "/usr/local/bin/etcd", | ||
| "/usr/local/bin/agnhost", |
There was a problem hiding this comment.
I don't think this will work. Have you tried it?
There was a problem hiding this comment.
in this article you can find out how the arguments would look like for the agnhost: https://kubernetes.io/blog/2022/05/13/grpc-probes-now-in-beta/
There was a problem hiding this comment.
@SergeyKanzhelev
Thanks for your review! I fixed the code so please check it!
Signed-off-by: Shogo Hida <shogo.hida@gmail.com>
| terminationGracePeriod := int64(30) | ||
| script := ` | ||
| _term() { | ||
| _term() { |
There was a problem hiding this comment.
Blank space was deleted automatically by Visual Studio Code.
| touch /tmp/liveness | ||
|
|
||
| while true; do | ||
| while true; do |
There was a problem hiding this comment.
Blank space was deleted automatically by Visual Studio Code.
| } | ||
|
|
||
| pod := gRPCServerPodSpec(nil, livenessProbe, "etcd") | ||
| pod := gRPCServerPodSpec(nil, livenessProbe, "agnhost") |
There was a problem hiding this comment.
did you run the test? You still hasn;t updated the port in liveness probe definition on the line 527
There was a problem hiding this comment.
Oh sorry about that. I changed it to 5000
Signed-off-by: Shogo Hida <shogo.hida@gmail.com>
SergeyKanzhelev
left a comment
There was a problem hiding this comment.
/lgtm
/ok-to-test
/triage accepted
/priority important-soon
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SergeyKanzhelev, shogohida The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: c09ab35f0a3d01295af4a517dc5d0ec97e528ab6 |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Changes etcd image to agnhost image
Which issue(s) this PR fixes:
Fixes #115781
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: