jme3-core: make PrimitiveAllocator default#1915
Draft
Ali-RS wants to merge 2 commits intojMonkeyEngine:masterfrom
Draft
jme3-core: make PrimitiveAllocator default#1915Ali-RS wants to merge 2 commits intojMonkeyEngine:masterfrom
Ali-RS wants to merge 2 commits intojMonkeyEngine:masterfrom
Conversation
…ses unsafe and needs to add special flags to work on java 11+ ("--add-opens=java.base/jdk.internal.ref=ALL-UNNAMED", "--add-exports=java.base/sun.nio.ch=ALL-UNNAMED"). It might break again in the future.
Contributor
|
How is the status of this pull request? We have faced the same issues in our game and looking forward for your fix. :) |
Member
Author
|
Hi, I am not sure when/if this would be merged but you can switch it to the primitive allocator by passing a system property:
by the way, if you use jme3-lwjgl3, you do not need to do this as lwjgl3 has its own allocator. |
Contributor
|
Oh, I wasn't aware of the lwjgl3 option. I switched our projet to it and everything was working as before, just without the Error from the ReflectionAllocator. Thank you for this nice little hint. :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ReflectionAllocator uses unsafe and needs to add special flags to work on java 11+ ("--add-opens=java.base/jdk.internal.ref=ALL-UNNAMED", "--add-exports=java.base/sun.nio.ch=ALL-UNNAMED"). It might break again in the future.
Related forum post:
https://hub.jmonkeyengine.org/t/deprecating-reflectionallocator/46350
Related issue: #1674