PCAN: add support for detecting available channels#640
Merged
felixdivo merged 7 commits intohardbyte:developfrom Jul 18, 2019
jsee23:pcan-config-query
Merged
PCAN: add support for detecting available channels#640felixdivo merged 7 commits intohardbyte:developfrom jsee23:pcan-config-query
felixdivo merged 7 commits intohardbyte:developfrom
jsee23:pcan-config-query
Conversation
Collaborator
|
Thank you for improving this! It seems like some tests do net yet work, any the formatter will probably spit out some improvements as well. Generally, the |
felixdivo
reviewed
Jul 15, 2019
Co-Authored-By: Felix Divo <felixdivo@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## develop #640 +/- ##
===========================================
- Coverage 63.54% 63.46% -0.09%
===========================================
Files 66 66
Lines 5991 6016 +25
===========================================
+ Hits 3807 3818 +11
- Misses 2184 2198 +14 |
Contributor
Author
|
Thanks for your feedback, I will check the tests by this evening. |
14 tasks
felixdivo
approved these changes
Jul 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.