Skip to content

Auto deploy#535

Merged
felixdivo merged 8 commits intodevelopfrom
auto-deploy
Apr 6, 2019
Merged

Auto deploy#535
felixdivo merged 8 commits intodevelopfrom
auto-deploy

Conversation

@hardbyte
Copy link
Copy Markdown
Owner

No description provided.

@felixdivo
Copy link
Copy Markdown
Collaborator

Why did you remove all of the comments?

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2019

Codecov Report

Merging #535 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #535   +/-   ##
========================================
  Coverage    64.44%   64.44%           
========================================
  Files           63       63           
  Lines         5651     5651           
========================================
  Hits          3642     3642           
  Misses        2009     2009

@felixdivo
Copy link
Copy Markdown
Collaborator

See #521

@hardbyte
Copy link
Copy Markdown
Owner Author

hardbyte commented Apr 1, 2019

@felixdivo I didn't mean to remove the comments - I used the travis tool to encrypt the deploy secret and it changed the whole file :-/

@hardbyte hardbyte requested a review from felixdivo April 1, 2019 07:49
Copy link
Copy Markdown
Collaborator

@felixdivo felixdivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, except that the comments are removed. If that is fixed, it's a nice addition.

@felixdivo felixdivo added this to the 3.2 Release milestone Apr 6, 2019
@hardbyte hardbyte requested a review from felixdivo April 6, 2019 10:25
Copy link
Copy Markdown
Collaborator

@felixdivo felixdivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@felixdivo felixdivo merged commit c17ff89 into develop Apr 6, 2019
@felixdivo felixdivo deleted the auto-deploy branch April 6, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants