v2.1.0 - optionally not send a message immediately when you call modify_data on a BCM cyclic Tx task#399
Closed
brad-drehmer wants to merge 3 commits intohardbyte:developfrom
Closed
v2.1.0 - optionally not send a message immediately when you call modify_data on a BCM cyclic Tx task#399brad-drehmer wants to merge 3 commits intohardbyte:developfrom
brad-drehmer wants to merge 3 commits intohardbyte:developfrom
Conversation
Optionally NOT send a message immediately when you call modify_data on a BCM cyclic Tx task. It is likely not desirable to disrupt the message period controlled by the BCM. When modifying data, this feature allows you to maintain the message period and just transmit the new value whenever the next message is due for transmission
Collaborator
|
This was fixed in v2.2.0, in pull request #323. You are right that the timer should not be restarted if data is modified. |
Collaborator
|
So this can be closed? Sorry, for us to being able to include your effort in the library. |
Owner
|
Thanks for the contribution all the same. If you think it is still important/useful to provide the user with the option of restarting the timer as soon as they change the data please open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code was from the v2.1.0 release. It looks like socketcan_native.py no longer exists, but the concept should remain the same.
The issue was that when you call modify_data on a BCM cyclic Tx task, the message was sent immediately on the CAN bus. The code in this pull request adds the ability to optionally not send a message immediately. It is likely not desirable to disrupt the message period controlled by the BCM. When modifying data, this feature allows you to maintain the message period and just transmit the new value whenever the next message is due for transmission