Add asyncio support#388
Merged
christiansandberg merged 13 commits intohardbyte:developfrom Sep 5, 2018
Merged
Conversation
Collaborator
|
Uhh, looks really nice! |
Codecov Report
@@ Coverage Diff @@
## develop #388 +/- ##
===========================================
+ Coverage 59.25% 59.26% +<.01%
===========================================
Files 55 55
Lines 4261 4328 +67
===========================================
+ Hits 2525 2565 +40
- Misses 1736 1763 +27 |
Collaborator
|
Could you add a test for this on |
Collaborator
Author
|
The problem is that testing this will require statements that are not available in Python 2.7 so it won’t even be able to read the file. Not sure if that can be handled by pytest. |
Collaborator
|
Hm, I see. |
felixdivo
reviewed
Aug 31, 2018
hardbyte
approved these changes
Aug 31, 2018
Owner
hardbyte
left a comment
There was a problem hiding this comment.
Very cool!
I tried it out on python 3.6 and saw messages on a vcan bus, and verified that the new test correctly gets skipped on python 2.7.
Thanks for your patience with this addition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for developing asyncio applications with python-can more easily. This can be useful when implementing protocols that handles simultaneous connections to many nodes since you can write synchronous looking code without handling multiple threads and locking mechanisms.
For information I started working a year ago or so on adding native asyncio support for each interface but abandoned it since not all API's support callbacks and the performance would probably be worse than using a thread for reading messages.