Syntax highlighting for the example code in README.rst#368
Merged
Syntax highlighting for the example code in README.rst#368
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #368 +/- ##
========================================
Coverage 58.32% 58.32%
========================================
Files 54 54
Lines 4250 4250
========================================
Hits 2479 2479
Misses 1771 1771Continue to review full report at Codecov.
|
Collaborator
Author
|
@hardbyte Why is only Travis CI, and not AppVeyor was well required for merging? And BTW, nice to see that they are now required for the Maybe a single review should be required for merging as well? That would then enforce our current pull request policy. |
hardbyte
approved these changes
Jul 19, 2018
Owner
hardbyte
left a comment
There was a problem hiding this comment.
So hard to review such a large and complex PR. :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.