Conversation
…inx warnings to 37
Codecov Report
@@ Coverage Diff @@
## develop #367 +/- ##
===========================================
+ Coverage 58.26% 58.32% +0.06%
===========================================
Files 54 54
Lines 4248 4250 +2
===========================================
+ Hits 2475 2479 +4
+ Misses 1773 1771 -2
Continue to review full report at Codecov.
|
hardbyte
left a comment
There was a problem hiding this comment.
Looks good just a couple of small points
|
|
||
| A thread safe bus wrapper is also available, see `Thread safe bus`_. | ||
|
|
||
| Autoconfig Bus |
There was a problem hiding this comment.
Why moving this autoconfig bus before the BusABC?
There was a problem hiding this comment.
Because that is the main entry point into the library if you want to communicate.
There was a problem hiding this comment.
Well it is a wrapper/constructor around a concrete implementation of the BusABC - both should be covered and I assumed that the more interesting/important item was the class that acts as the primary interface.
Leave your changes - we should just add a clarifying note to the top to help explain the class structure to users.
doc/interfaces/slcan.rst
Outdated
| For example use ``/dev/ttyUSB0@115200`` or ``COM4@9600`` | ||
|
|
||
| .. note: | ||
| An Arduino-Interface could easyly be build wit this: |
I cleaned up some parts of the library, and reduced the number of Sphinx doc warnings from 43 (or 55 depending on what you compare it with) to 39. Fixing some warnings created new ones.
Related to #262