Failing "setup.py test" on develop branch after 3.1.1 in Windows

[bhass1]

OS: Windows 7
Python: 3.6.1
Branch: develop
Commit: dd89de4.....

Description:
Windows doesn't like the changes between release-3.1.1 and referenced branch+commit above.

Running "py -3 setup.py test" from the tip of branch "release-3.1.1" completes with an error on simplecyclic test which is fixed in PR #540 . The same exact command run on the above referenced branch+commit fails with the following. See image below.

I haven't tried to root-cause the issue yet. Appears one of the newly supported interfaces causes a hiccup.

[bhass1]

I need to downgrade pytest from 4.3.0 to 3.6.0 before "setup.py test" will work from release-3.1.1 branch. But after downgrading pytest and using the release-3.1.1 branch on the same machine, the same area of output looks like the following:

... and eventually fails on the simplecyclic test (fixed in PR #540) ...

[bhass1]

The two differences are:
WARNING:can.interfaces.iscan:Failed to load IS-CAN driver: [WinError 126] The specified module could not be found
ERROR:can.interfaces.nican:Failed to load NI-CAN driver: [WinError 126] The specified module could not be found

[felixdivo]

Travis CI and APpveyor call our tests using the command pytest. Does that work on your machine? (It shouldn't make a difference, else we have another problem ...)

[felixdivo]

Could it be, that your test runner executes the generic ReaderWriterTest as a test, and ignoring the __test__ = False attribute? Because all other tests that override that class also seem to implement @abstractmethod def _setup_instance(self).

[bhass1]

Using pytest version 4.3.0 from "pip install pytest==4.3.0" with Python 3.6.1 :

Also tested with Python 2.7.12 and get the same error.

[felixdivo]

Looks like you did not install all dependencies there. Please install them with:

pip install .[test]

These are missing and causing the problems. That should work with Python 2 & 3, since it works on Travis CI as well.

[felixdivo]

here is the entire diff: a6a4447...dd89de4

The only relevant change I can see are the changed dependencies: a6a4447...dd89de4#diff-2eeaed663bd0d25b7e608891384b7298L33

[bhass1]

pip install .[test] did the trick for running pytest to completion without error.

py -3 setup.py test is still failing at the same spot.

Perhaps the setup.py test should be deprecated for the use of pytest instead? In either case, I think it would be helpful if the documentation was updated to include pip install .[test].

Regarding the setup.py test issue... what makes you think it is involved with ReaderWriterTest? Is there something I can try to help diagnose the root cause of the error?

[felixdivo]

I think it would be helpful if the documentation was updated to include pip install .[test].

This is actually explained here:
"Maybe, you need to execute pip3 install python-can[test] (or only pip for Python 2), if some dependencies are missing."

[felixdivo]

I have looked in the docs of pytest, and found that this might be missing:

[aliases]
test=pytest

Does that solve the errors?

[felixdivo]

what makes you think it is involved with ReaderWriterTest?

Hm, all tests in that file inherit from that class, which is itself not executed as a test, because it has that __test__ = False set. And the NotImplementedError would only be raised if
(a) that test class is executed directly (not only serving as a superclass), or
(b) some other tests is extending it but does not override _setup_instance(), or
(c) for some reason not the overridden method but the original one is called (this would be the strangest I think ^^).