-
Notifications
You must be signed in to change notification settings - Fork 1.7k
BigQuery properties issues in query.py #3001
Copy link
Copy link
Closed
Labels
api: bigqueryIssues related to the BigQuery API.Issues related to the BigQuery API.backendpriority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Metadata
Metadata
Assignees
Labels
api: bigqueryIssues related to the BigQuery API.Issues related to the BigQuery API.backendpriority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
(1) When I run a long, non-cached, sync query --
... it often returns without being complete. I call
query_job.fetch_data(page_token=None)to try and get the result. If the query finished by that time -- all is well, however if doesn't, the server response doesn't include the job's name (jobReference.jobId); since the state is being completely erased/rewritten, following calls tofetch_datafail withValueError("Query not yet executed: call 'run()'").(2) The
runmethod checksif self._job is not None:to prevent a double invocation. It should however run that check withself.jobinstead (no underscore), asself._jobis only set if you previously usedself.job.(3) It would be 'nicer' if the total_rows property return an integer (or None) rather than a string.