Bucket.upload: charset not appended on application/javascript contentType

[beeant]

I did console.log(metadata) on Bucket.upload API. and charset=utf-8 doesn't seem to be appended for application/javascript.

https://github.com/GoogleCloudPlatform/gcloud-node/blob/d36802f03267a4c890a2f5203a8a46a452b329cf/lib/storage/bucket.js#L418

How about using https://github.com/jshttp/mime-types instead of https://github.com/broofa/node-mime?

node-mime doesn't seem to return any charset on application/javascript, but mime-types does.

[stephenplusplus]

mime-types looks good to me. 👍

[stephenplusplus]

I'll wait a little bit to see how jshttp/mime-types#15 shakes out. In the meantime, you are free to use mime-types in your app, then set its value on the metadata object passed to .upload:

bucket.upload("file.js", { contentType: "result from mimetypes" }, function (err, file) {})

[beeant]

Thank you for your reply.
Thank you for the suggestion too, and yes, that's what I'm doing right now.
I'll be keeping track for the update and remove the unnecessary parts of mime-types codes in my app after the update.