Skip to content
This repository was archived by the owner on Jul 13, 2025. It is now read-only.

Update properties file path in Java XSettings#1166

Merged
shinfan merged 3 commits intogoogleapis:masterfrom
shinfan:master
Apr 12, 2017
Merged

Update properties file path in Java XSettings#1166
shinfan merged 3 commits intogoogleapis:masterfrom
shinfan:master

Conversation

@shinfan
Copy link
Copy Markdown
Contributor

@shinfan shinfan commented Apr 5, 2017

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 5, 2017

Codecov Report

Merging #1166 into master will increase coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1166      +/-   ##
============================================
+ Coverage     86.04%   86.09%   +0.05%     
- Complexity     3667     3687      +20     
============================================
  Files           372      372              
  Lines         14441    14553     +112     
  Branches       1612     1627      +15     
============================================
+ Hits          12426    12530     +104     
- Misses         1580     1587       +7     
- Partials        435      436       +1
Impacted Files Coverage Δ Complexity Δ
.../api/codegen/viewmodel/StaticLangSettingsView.java 100% <ø> (ø) 8 <0> (ø) ⬇️
...m/google/api/codegen/transformer/SurfaceNamer.java 78.47% <0%> (-1.18%) 170 <0> (+2)
.../transformer/java/JavaGapicSurfaceTransformer.java 98.88% <100%> (+0.07%) 43 <0> (ø) ⬇️
...api/codegen/transformer/java/JavaSurfaceNamer.java 85.24% <75%> (+2.22%) 30 <0> (+5) ⬆️
...main/java/com/google/api/codegen/LanguageUtil.java 31.57% <0%> (-5.27%) 4% <0%> (-1%)
...om/google/api/codegen/discovery/DefaultString.java 87.67% <0%> (-1.08%) 23% <0%> (-4%)
...java/com/google/api/codegen/DiscoveryImporter.java 90.67% <0%> (-0.6%) 62% <0%> (+2%)
.../transformer/ruby/RubyGapicSurfaceTransformer.java 100% <0%> (ø) 10% <0%> (ø) ⬇️
...codegen/viewmodel/StaticLangPagedResponseView.java 100% <0%> (ø) 2% <0%> (ø) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbb99e1...4b784ac. Read the comment docs.

public String getArtifactId(Interface service) {
List<String> tokens =
Splitter.on('.').splitToList(service.getModel().getServiceConfig().getName());
return tokens.size() > 0 ? "google-cloud-" + tokens.get(0) : null;

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

List<String> packagePath = Splitter.on(".").splitToList(getPackageName());
if (packagePath.size() > 3) {
// Remove the "spi.{version}" suffix
return Joiner.on("/").join(packagePath.subList(0, packagePath.size() - 2));

This comment was marked as spam.

This comment was marked as spam.

@shinfan
Copy link
Copy Markdown
Contributor Author

shinfan commented Apr 12, 2017

PTAL

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

LGTM

@shinfan shinfan merged commit 70076f2 into googleapis:master Apr 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants