This repository was archived by the owner on Jul 13, 2025. It is now read-only.
Update properties file path in Java XSettings#1166
Merged
shinfan merged 3 commits intogoogleapis:masterfrom Apr 12, 2017
Merged
Update properties file path in Java XSettings#1166shinfan merged 3 commits intogoogleapis:masterfrom
shinfan merged 3 commits intogoogleapis:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1166 +/- ##
============================================
+ Coverage 86.04% 86.09% +0.05%
- Complexity 3667 3687 +20
============================================
Files 372 372
Lines 14441 14553 +112
Branches 1612 1627 +15
============================================
+ Hits 12426 12530 +104
- Misses 1580 1587 +7
- Partials 435 436 +1
Continue to review full report at Codecov.
|
| public String getArtifactId(Interface service) { | ||
| List<String> tokens = | ||
| Splitter.on('.').splitToList(service.getModel().getServiceConfig().getName()); | ||
| return tokens.size() > 0 ? "google-cloud-" + tokens.get(0) : null; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| List<String> packagePath = Splitter.on(".").splitToList(getPackageName()); | ||
| if (packagePath.size() > 3) { | ||
| // Remove the "spi.{version}" suffix | ||
| return Joiner.on("/").join(packagePath.subList(0, packagePath.size() - 2)); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
PTAL |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More context: googleapis/google-cloud-java#1863