cmd/viewcore: ignore mapped files without executable regions#4
cmd/viewcore: ignore mapped files without executable regions#4bozaro wants to merge 1 commit intogolang:masterfrom
Conversation
This change ignores files without executable regions to avoid errors on loading debug info from this files. In our case we got confusing `bad magic number` errors on parsing files with GeoIP data.
|
This PR (HEAD: fe13896) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/debug/+/232460 to see it. Tip: You can toggle comments from me using the |
|
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/232460. |
|
Message from Keith Randall: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/232460. |
|
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/232460. |
This change ignores files without executable regions to avoid errors on loading debug info from this files.
In our case we got confusing
bad magic numbererrors on parsing files with GeoIP data.