Skip to content

Fixed #93 Make puppet version check respect env vars#94

Merged
kpaulisse merged 1 commit intogithub:masterfrom
dylanratcliffe:master
Mar 17, 2017
Merged

Fixed #93 Make puppet version check respect env vars#94
kpaulisse merged 1 commit intogithub:masterfrom
dylanratcliffe:master

Conversation

@dylanratcliffe
Copy link

Overview

This pull request fixes #93

It adds an optional param to the version check method which, if supplied will allow the command to retain extra environment variables as expected

Checklist

  • Make sure that all of the tests pass, and fix any that don't. Just run rake in your checkout directory, or review the CI job triggered whenever you push to a pull request.
  • Make sure that there is 100% test coverage by running rake coverage:spec or ignoring untestable sections of code with # :nocov comments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests.
  • If you have added a new command line option, we would greatly appreciate a corresponding integration test that exercises it from start to finish. This is optional but recommended.
  • If you have added any new gem dependencies, make sure those gems are licensed under the MIT or Apache 2.0 license. We cannot add any dependencies on gems licensed under GPL.
  • If you have added any new gem dependencies, make sure you've checked in a copy of the .gem file into the vendor/cache directory.

/cc #93 @kpaulisse

kpaulisse pushed a commit that referenced this pull request Mar 16, 2017
@kpaulisse kpaulisse mentioned this pull request Mar 16, 2017
@kpaulisse kpaulisse merged commit 17cb262 into github:master Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Puppet version loading does not respect --pass-env-vars

2 participants