Add option to ignore whitespace in yaml file diff#46
Merged
Conversation
added 13 commits
January 4, 2017 16:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During some Puppet 3.x to 4.x updates, we've observed that YAML files we generate within Puppet using the ruby libraries can exhibit different white-space characteristics, but the parsed YAML objects are identical.
This PR adds a new option
--filters YAMLwhich will further compare the content of any changes to files with an extension.ymlor.yamland ignore the change if the files parse to the same objects. (Note: In the future, additional filtering options like this will be added to--filtersinstead of having their own named option.)This should probably be used sparingly and situationally, because you'll also lose reporting on changes to comments (if you care).