Add ability to set storeconfig_backends#312
Merged
jhongturney merged 5 commits intomasterfrom Sep 16, 2024
Merged
Conversation
cjmartian
reviewed
Sep 13, 2024
cjmartian
approved these changes
Sep 13, 2024
Contributor
cjmartian
left a comment
There was a problem hiding this comment.
LGTM, just had a question - not blocking. Thanks for doing this!
jhongturney
approved these changes
Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request adds the ability to set the
storeconfigs_backendoption. This allows for the selection of alternate backends for storing catalog data.The change allows the
octocatalog-diffcommand to now accept the paramater--storeconfigs-backend [puppetdb|yaml|json]which sets the terminus for storeconfigs on the underlyingpuppet catalog compilecommand.The default for
storeconfigs_backendhas been defaulted topuppetdbto maintain backwards compatibility.Checklist
rakein your checkout directory, or review the CI job triggered whenever you push to a pull request.rake coverage:specor ignoring untestable sections of code with# :nocovcomments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests..gemfile into the vendor/cache directory./cc [related issues] [teams and individuals, making sure to mention why you're CC-ing them]