Set URI port without re-setting the constants#149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets the URI default ports for puppetdb without overriding the constants in the module. We found that when including octocatalog-diff as a gem into other projects, the port 8081 (default for puppetdb lookup) was taking the place of the default port 443, and breaking things. Therefore,
parse_urlin the puppetdb class is being updated to set the URI port locally on the object rather than changing the default in the entire class.Also, it's been a while since there was a build of this project, and Travis has deprecated their precise build environment since then. There were a few tweaks to the bootstrapping and environment to get everything running on the trusty environment. I also bumped the gems in the repo's cache.
Fixes #142