Skip to content

credential type is not a secret#1517

Merged
jakecoffman merged 1 commit intomainfrom
reveal-type
Jul 15, 2025
Merged

credential type is not a secret#1517
jakecoffman merged 1 commit intomainfrom
reveal-type

Conversation

@jakecoffman
Copy link
Member

I noticed the type is being hidden:

    "credentials-metadata": [
      {
        "type": "***",
        "host": "github.com"
      },
      {
        "type": "***",
        "url": "https://maven.pkg.github.com/github/*"
      },

There's no need to do that so I've added it to the non-secret allow list.

Copilot AI review requested due to automatic review settings July 15, 2025 17:58
@jakecoffman jakecoffman requested a review from a team as a code owner July 15, 2025 17:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the credential logging configuration to prevent the type field from being masked in credential metadata logs. The change allows the credential type to be visible in logs while keeping sensitive information like passwords properly masked.

  • Adds type to the non-secret allow list for credential logging

@jakecoffman jakecoffman merged commit f63d31a into main Jul 15, 2025
9 checks passed
@jakecoffman jakecoffman deleted the reveal-type branch July 15, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants