Rust: Disambiguate types inferred from trait bounds#21464
Draft
hvitved wants to merge 5 commits intogithub:mainfrom
Draft
Rust: Disambiguate types inferred from trait bounds#21464hvitved wants to merge 5 commits intogithub:mainfrom
hvitved wants to merge 5 commits intogithub:mainfrom
Conversation
4d48515 to
902e953
Compare
902e953 to
1dbd888
Compare
| hasTypeConstraint(tt, type, constraint) and | ||
| rootTypesSatisfaction(type, constraint, abs, cond, _) and | ||
| predicate potentialInstantiationOf(Term term, TypeAbstraction abs, TypeMention cond) { | ||
| exists(Constraint constraint, Type type, Type constraintRoot | |
1dbd888 to
7a5a89a
Compare
9300d8d to
e14936f
Compare
98a7ca6 to
be2a49b
Compare
be2a49b to
03a444d
Compare
03a444d to
8b7328d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain cases where a type implements the same trait but with different type arguments, we may infer overlapping types from trait bounds (see example in first commit).
In order to disambiguate, this PR takes the same approach as #21420, but lifting the idea from that PR into the shared type inference library, so it applies to both resolution of
<Foo as Bar<...>>paths as well as constraints on type parameters inside functions.