Repository model refactoring still to do

[jcansdale]

Copied from #2040

Still to do

• Read the RemoteRepositoryModel when we read the PR model from GraphQL, that way we can fix Fails to check out PR branch. #1986
• Change RemoteRepositoryModel.OwnerAccount to be a ActorModel instead of an IAccount (@grokys)
• Remove the Octicon from the model Refactor repository models (repository refactor part 1) #2008 (comment)
  

  VisualStudio/src/GitHub.Exports/Models/BranchModel.cs

  Line 36 in e3f8114

  Repository = branch.IsRemote ? gitService.CreateLocalRepositoryModel(branch.Remote.Url) : repo;

  (removed this code)
• Do we want RemoteRepositoryModel to continue implementing IEquatable<RemoteRepositoryModel> and IComparable<RemoteRepositoryModel>?
• Is TrimEnd needed here Refactor repository models (repository refactor part 1) #2008 (comment)
• When I change the name of the origin remote I get an exception at this line: Remove repository responsibilities from TeamExplorerServiceHolder (repository refactor part 2) #2025 (comment)

Possible bugs

• LocalRepositoryModel.GetHashCode and Equals should use consistent comparisons
  

  VisualStudio/src/GitHub.Exports/Models/LocalRepositoryModel.cs

  Line 36 in e3f8114

  return 17 * 23 + (Name?.GetHashCode() ?? 0) * 23 + (Owner?.GetHashCode() ?? 0) * 23 + (LocalPath?.TrimEnd('\\').ToUpperInvariant().GetHashCode() ?? 0);

  
  

  VisualStudio/src/GitHub.Exports/Models/LocalRepositoryModel.cs

  Line 55 in e3f8114

  string.Equals(LocalPath?.TrimEnd('\\'), other.LocalPath?.TrimEnd('\\'), StringComparison.CurrentCultureIgnoreCase);

  
  OrdinalIgnoreCase or InvariantCultureIgnoreCase maybe?