ref(core): Do not emit spans for chats.create in google-genai#19990
Open
nicohrubec wants to merge 11 commits intodevelopfrom
Open
ref(core): Do not emit spans for chats.create in google-genai#19990nicohrubec wants to merge 11 commits intodevelopfrom
nicohrubec wants to merge 11 commits intodevelopfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Deps
Other
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧Core
Deps
Deps Dev
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
042667f to
cb797a1
Compare
16c5086 to
15e6af4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently emit spans for the google-genai
chats.create()API. I think this is basically useless becausechats.create()doesn't represent an actual interaction with an LLM model, instead it just constructs a local chat object as a result that then further exposes methods likesendMessage()that represent actual LLM interactions. This PR removes the spans forchats.create().Since this API is a special case where we actually need to proxy the return object instead of the method call itself we had some surrounding logic hardcoded to this method. To make this a bit more future proof and also more explicit we now add a
proxyResultPathfield to the method registry that allows to define this behavior in the method registry without needing any hardcoded logic. Another benefit this has is that the full logic in thecreateDeepProxymethods in all our client-proxy based AI integrations (google-genai, openai, anthropic) is now essentially the same so could potentially in the future be easily merged into a shared abstraction.Limitation: We do"loose" some data by not emitting this create span anymore, because the way this API works is that the user defines certain parameters only on the
chats.create()call and these are then subsequently used for eachchat.sendMessage()call. The correct way would be to send this data as part of eachchat.sendMessage()chat span. We can think about doing this as part of this PR or doing a follow up.Stacked on #19981.