Don't override @opts in create_client_from_token#168
Merged
agrare merged 1 commit intofog:masterfrom Jan 28, 2026
Merged
Conversation
`@opts` is already correctly set in `initialize` and if we override it, we disable SSL validation Fixes: efbeed4 Fixes: CVE-2026-1530
Contributor
Author
|
I'd also argue that |
Collaborator
I agree, I'm going to release a 1.5.1 with just this commit but if you want to make that change I'll do that in a 1.6.0 since it is a change in behavior |
Contributor
Author
|
Sure, thanks! Second PR: #169 |
Collaborator
agrare
added a commit
that referenced
this pull request
Jan 28, 2026
Fixed: - CVE-2026-1530 - Don't override @opts in create_client_from_token (#168)
Collaborator
|
Released in [v1.6.0] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@optsis already correctly set ininitializeand if we override it, we disable SSL validationhttps://bugzilla.redhat.com/show_bug.cgi?id=CVE-2026-1530
Fixes: efbeed4
Fixes: CVE-2026-1530