Open
Conversation
Entering the SDK via `su` breaks stdout/stderr permissions because the underlying /dev/pts/N device is still owned by root. `sudo` doesn't have this problem. Neither does `runuser`, which might be preferable, but the SDK doesn't have that. This was previously `sudo su`, so changing this to `sudo sudo` might seem logical, but I think the original `sudo` was only there to prevent `su` from asking for a password. That shouldn't happen with a single `sudo` call. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
This is used to read version.txt, which was written with single quotes when Jenkins reverted a build. These quotes were then erroneously written into /etc/os-release, which caused havoc. This has already been addressed in jenkins-os, but let's make this code more robust anyway. Fix this by grepping out the lines we need (in one go) and actually parsing them with Bash. Less safe, but we already parse version.txt with Bash in other places. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
I see a 25% improvement. `man make.conf` says that this can potentially result in build failures, but it seems unlikely when merely installing binary packages. I haven't had any issues after several local builds. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various SDK fixes
set_version --file /dev/stdoutwas broken.How to use
The most important thing to test is
./run_sdk_container.Testing done
I've used these changes locally for a few days. A Jenkins run passed, although we cannot currently run the arm64 tests.
changelog/directory (user-facing change, bug fix, security fix, update) -- N/A/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.