Open
Conversation
In browser-based environments, require("buffer") will fail unless
`buffer` is available as a dependency and can be provided by a
bundler. This used to automatically be the case in e.g. older
versions of Webpack, but since Webpack v5 no longer automatically
includes polyfills for Node built-ins, it can happen that the
`buffer` polyfill is no longer available in a project's dependency
tree.
|
safe buffer is only needed for node < v6 |
I'm pretty sure 90% of safe-buffer use cases nowadays are to polyfill node builtins (like in vite-plugin-node-polyfills). +1 for adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In browser-based environments, require("buffer") will fail unless
bufferis available as a dependency and can be provided by abundler. This used to automatically be the case in e.g. older
versions of Webpack, but since Webpack v5 no longer automatically
includes polyfills for Node built-ins, it can happen that the
bufferpolyfill is no longer available in a project's dependencytree.
Fixes #18 and nodejs/readable-stream#448.