feat(locale): add Japanese job definitions for person module#3705
feat(locale): add Japanese job definitions for person module#3705xDivisionByZerox merged 2 commits intofaker-js:nextfrom
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
May i just say this is a great example of a pull request!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3705 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 2996 3000 +4
Lines 236217 236293 +76
Branches 945 946 +1
=======================================
+ Hits 236159 236235 +76
Misses 58 58
🚀 New features to boost your workflow:
|
|
@matthewmayer Thank you so much! I’m really glad to hear that 🙏 I’ve been using this very helpful library for months, and I’ll do my best to contribute when possible. |
xDivisionByZerox
left a comment
There was a problem hiding this comment.
I have to agree with matthewmayer. This PR is a fantastic example of how locale PR should be, if you want the maintainers to review your changes quickly and not burn out while doing so.
Highly appreciated 🙌
|
@xDivisionByZerox Thank you so much, I really appreciate the feedback. I’m glad it made the review process easier🐣 |
|
@atzzCokeK would you be so kind and update the snapshot test in your branch again, when you have time? |
|
@xDivisionByZerox Sure, no problem. I will do it!🫡 |
Add job-related definitions for the Japanese (ja) locale: - job_descriptor: Senior, Lead, Chief, etc. (シニア、リード、チーフ等) - job_type: Manager, Engineer, Director, etc. (マネージャー、エンジニア等) - job_area: Sales, Marketing, HR, etc. (営業、マーケティング、人事等) These definitions enable faker.person.jobTitle() and related methods to generate Japanese job titles.
Japanese doesn't use spaces between words, so the job title pattern should be: "シニア営業マネージャー" instead of "シニア 営業 マネージャー"
7196604
0bd5f09 to
7196604
Compare
|
@xDivisionByZerox I've finished this. Could you review it when you have time? |
Summary
Add job-related definitions for the Japanese (ja) locale in the person module.
This enables
faker.person.jobTitle(),faker.person.jobDescriptor(),faker.person.jobArea(), andfaker.person.jobType()to generate Japanese job titles.Added files
job_descriptor.ts - Job title modifiers
job_type.ts - Job positions
job_area.ts - Job areas/departments
job_title_pattern.ts - Japanese-specific pattern without spaces
Japanese doesn't use spaces between words, so the pattern generates titles like:
Example output
Using
faker.person.jobTitle():Test plan
pnpm run generate:localesexecuted successfullypnpm run preflightpassed (all 52056 tests passed)