Enable CUDA mixed precision in NeuralNet#15
Open
avidaldo wants to merge 1 commit intofachu000:flexible_trainingfrom
Open
Enable CUDA mixed precision in NeuralNet#15avidaldo wants to merge 1 commit intofachu000:flexible_trainingfrom
avidaldo wants to merge 1 commit intofachu000:flexible_trainingfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces CUDA-focused mixed-precision behavior in NeuralNet to improve throughput by enabling TF32 matmul precision and running forward passes under CUDA autocast (bf16), while attempting to keep loss computation in fp32 for stability.
Changes:
- Enable TF32 matmul precision on CUDA via
torch.set_float32_matmul_precision('high'). - Wrap training/eval forward passes in
torch.autocast(..., dtype=torch.bfloat16)when running on CUDA. - Cast model outputs to fp32 before loss computation (currently only for tensor outputs).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
torch.set_float32_matmul_precision('high')).bfloat16for training and prediction.Why
enabled=self.device_type == 'cuda').Scope
include/neural_net/neural_net.pyonlyValidation
pytestis not installed (No module named pytest).