Skip to content

Use resfo-utilities SummaryReader for view_summary#1071

Merged
eivindjahren merged 1 commit intomainfrom
use_summary_reader_from_resfo_utilities
Nov 4, 2025
Merged

Use resfo-utilities SummaryReader for view_summary#1071
eivindjahren merged 1 commit intomainfrom
use_summary_reader_from_resfo_utilities

Conversation

@eivindjahren
Copy link
Copy Markdown
Collaborator

No description provided.

@eivindjahren eivindjahren force-pushed the use_summary_reader_from_resfo_utilities branch 8 times, most recently from 8262f8c to 2d56192 Compare November 4, 2025 10:51
@eivindjahren eivindjahren self-assigned this Nov 4, 2025
@eivindjahren eivindjahren moved this to Ready for Review in SCOUT Nov 4, 2025
@eivindjahren eivindjahren requested a review from Copilot November 4, 2025 11:09
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the view_summary package to use the external resfo-utilities library instead of maintaining its own implementation of summary parsing functionality. The migration consolidates code by removing local implementations and relying on the external library for summary file reading, key type identification, and summary key generation.

Key changes:

  • Replaced local resfo usage with resfo-utilities library's SummaryReader API
  • Removed local implementations of summary_key_type.py, summary_generator.py, and egrid_generator.py files
  • Updated exception handling from resfo.ResfoParsingError to InvalidSummaryError

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test_requirements.txt Adds resfo-utilities[testing]>=0.2.0 dependency for test utilities
setup.py Replaces resfo dependency with resfo-utilities>=0.2.0
python/view_summary/summary_key_type.py Entire file removed as functionality moved to resfo-utilities
python/view_summary/main.py Refactored to use SummaryReader API instead of direct resfo parsing
python/tests/test_view_summary.py Updated imports and test expectations for new library
python/tests/test_summary_key_type.py Simplified tests to only verify compatibility with resdata
python/tests/summary_generator.py Removed as testing utilities now provided by resfo-utilities
python/tests/egrid_generator.py Removed as no longer needed
python/tests/rd_tests/test_rd_sum.py Updated imports to use resfo-utilities.testing
.github/workflows/testing.yml Removed doctest execution for removed module

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread python/view_summary/__main__.py Outdated
Comment thread python/tests/test_view_summary.py
@eivindjahren eivindjahren force-pushed the use_summary_reader_from_resfo_utilities branch 3 times, most recently from 58bc8c7 to e493e58 Compare November 4, 2025 12:55
@github-project-automation github-project-automation bot moved this from Ready for Review to Reviewed in SCOUT Nov 4, 2025
@eivindjahren eivindjahren force-pushed the use_summary_reader_from_resfo_utilities branch from e493e58 to 57be9d2 Compare November 4, 2025 13:25
@eivindjahren eivindjahren merged commit 20009ec into main Nov 4, 2025
22 checks passed
@eivindjahren eivindjahren deleted the use_summary_reader_from_resfo_utilities branch November 4, 2025 13:30
@github-project-automation github-project-automation bot moved this from Reviewed to Done in SCOUT Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants