Use resfo-utilities SummaryReader for view_summary#1071
Merged
eivindjahren merged 1 commit intomainfrom Nov 4, 2025
Merged
Conversation
8262f8c to
2d56192
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the view_summary package to use the external resfo-utilities library instead of maintaining its own implementation of summary parsing functionality. The migration consolidates code by removing local implementations and relying on the external library for summary file reading, key type identification, and summary key generation.
Key changes:
- Replaced local
resfousage withresfo-utilitieslibrary'sSummaryReaderAPI - Removed local implementations of
summary_key_type.py,summary_generator.py, andegrid_generator.pyfiles - Updated exception handling from
resfo.ResfoParsingErrortoInvalidSummaryError
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test_requirements.txt | Adds resfo-utilities[testing]>=0.2.0 dependency for test utilities |
| setup.py | Replaces resfo dependency with resfo-utilities>=0.2.0 |
| python/view_summary/summary_key_type.py | Entire file removed as functionality moved to resfo-utilities |
| python/view_summary/main.py | Refactored to use SummaryReader API instead of direct resfo parsing |
| python/tests/test_view_summary.py | Updated imports and test expectations for new library |
| python/tests/test_summary_key_type.py | Simplified tests to only verify compatibility with resdata |
| python/tests/summary_generator.py | Removed as testing utilities now provided by resfo-utilities |
| python/tests/egrid_generator.py | Removed as no longer needed |
| python/tests/rd_tests/test_rd_sum.py | Updated imports to use resfo-utilities.testing |
| .github/workflows/testing.yml | Removed doctest execution for removed module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
58bc8c7 to
e493e58
Compare
SAKavli
approved these changes
Nov 4, 2025
e493e58 to
57be9d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.