[Android] System Fonts fix

[kubaflo]

Issues Fixed

Fixes #19556

Before	After

[ghost]

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[jsuarezruiz]

Waiting CI to pass tests and generate the reference snapshot.

[jonathanpeppers]

@jsuarezruiz how do we get the screenshot? this looks ok to merge now otherwise.

[rmarinho]

Right now, you need to go to the UITest run https://dev.azure.com/xamarin/public/_build/results?buildId=110953&view=ms.vss-test-web.build-test-results-tab&runId=2620968&resultId=100163&paneView=debug
And check the failed test .

Then go to the Attachments and download the image for the test SystemFontsShouldRenderCorrectly

[rmarinho]

[AlleSchonWeg]

Hi,
thank you for fixing my issue ;)
But this should work also on API < 28. I know you using a Typeface.Create which is only available above 28. In XF it works below 28. So i'm not sure if this is the correct overload.

Edit:
Sorry, i thought you implemented the API check. Below API 28 all works as it should. Inspired from your fix i tried to make it work for other "styles"

		Typeface? CreateTypeface((string? fontFamilyName, FontWeight weight, bool italic) fontData)
		{
			var (fontFamily, weight, italic) = fontData;
			fontFamily ??= string.Empty;
			var style = ToTypefaceStyle(weight, italic);

			var result = Typeface.Default;
			var isDefaultTypeface = false;
			if (!string.IsNullOrWhiteSpace(fontFamily))
			{
				if (LoadDefaultTypeface(fontFamily) is Typeface systemTypeface)
				{
					result = systemTypeface;
					isDefaultTypeface = true;
				}
				else if (GetFromAssets(fontFamily) is Typeface typeface)
					result = typeface;
				else
					result = Typeface.Create(fontFamily, style);
			}

			if (OperatingSystem.IsAndroidVersionAtLeast(28))
				result = Typeface.Create(result, (!isDefaultTypeface || result == null) ? (int)weight : result.Weight, italic);
			else
				result = Typeface.Create(result, style);

			return result;
		}

Thank you

[kubaflo]

@jonathanpeppers I've added a commit with your suggested changes. Thanks for the tips!

[jonathanpeppers]

LGTM, if the test & screenshot are working. 👍

[rmarinho]

/azp run MAUI-UITests-public

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[rmarinho]

/azp run MAUI-UITests-public

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).