fix: correct MemberAdded event remove accessor#280
Merged
sakno merged 1 commit intodotnet:developfrom Mar 25, 2026
Merged
Conversation
Collaborator
|
Many thanks for your contribution! Could you please change the destination branch to |
Contributor
Author
|
Done, changed the base branch to develop. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, great library — thanks for maintaining it!
We noticed a small copy-paste issue in the MemberAdded event and put together a fix. Should be straightforward to review.
In RaftCluster.Membership.cs, the MemberAdded event's remove accessor targets memberRemovedHandlers instead of memberAddedHandlers. This means unsubscribing from MemberAdded never actually removes the handler (memory leak), and accidentally removes a MemberRemoved handler instead.
The MemberRemoved event right below it (line 121) is wired correctly, so this is just a typo in the copy.