Changed configured OPCache values for Maximun Perfomance in D8#156
Closed
rolandocaldas wants to merge 1 commit intodocker-library:masterfrom
Closed
Changed configured OPCache values for Maximun Perfomance in D8#156rolandocaldas wants to merge 1 commit intodocker-library:masterfrom
rolandocaldas wants to merge 1 commit intodocker-library:masterfrom
Conversation
Member
|
I think this seems like a good change but this would need to also be done in Maybe something like this at the end of the # untested
if [ "$version" = '7' ]; then
sed -ri \
-e 's/(opcache.memory_consumption)=256/\1=128/' \
-e 's/(opcache.max_accelerated_files)=20000/\1=4000/' \
-e '/symfony/Id' \
"$version/$variant/Dockerfile"
fi |
Member
|
This would probably be easier to implement in the templates themselves now with #190 👀 (No more hacky I'm going to close for now, but would love to see a new PR that implements this (especially one that links to the appropriate Drupal/Symphony documentation for where this recommendation comes from 👍). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #155