skpkg: use package update to run skpkg on files#87
skpkg: use package update to run skpkg on files#87zmx27 wants to merge 5 commits intodiffpy:mainfrom
Conversation
|
@sbillinge ready for review |
docs/source/license.rst
Outdated
| BSD 3-Clause License | ||
|
|
||
| Copyright (c) 2025, The Trustees of Columbia University in the City of New York. | ||
| Copyright (c) 2025-2026, The Trustees of Columbia University in the City of New York. |
There was a problem hiding this comment.
something is wrong here. The dates should go back to much earlier, so I think something got lost over time. Also, we are moving to assigning copyright to "contributors to " and having the dates as -present
There was a problem hiding this comment.
I checked the git history of this file and it seems like this file has not been modified since this repo first got skpkg back in 2025. To address the dates issue, I will simply copy paste the contents of the LICENSE.rst file, which contains that go back to 2009. However, could you clarify what you mean by assigning copyright to "contributors to "? So for example, would I replace The Trustees of Columbia University in the City of New York. with Contributors to pyobjcryst here??
src/pyobjcryst/__init__.py
Outdated
| ############################################################################## | ||
| # | ||
| # (c) 2025 The Trustees of Columbia University in the City of New York. | ||
| # (c) 2025-2026 The Trustees of Columbia University in the City of New York. |
There was a problem hiding this comment.
please see comment above about dates.
LICENSE.rst
Outdated
| Copyright (c) 2014-2019, Brookhaven Science Associates, Brookhaven National Laboratory | ||
|
|
||
| Copyright (c) 2024-2025, The Trustees of Columbia University in the City of New York. | ||
| Copyright (c) 2024-2026, The Trustees of Columbia University in the City of New York. |
| exclude = [] # exclude packages matching these glob patterns (empty by default) | ||
| namespaces = false # to disable scanning PEP 420 namespaces (true by default) | ||
|
|
||
| [project.scripts] |
There was a problem hiding this comment.
check that this exists and that we want it. @vincefn pyobjcryst is just a library and doesn't need an app, but by default in scikit-package that we are using now, if no app exists it seeds the project with a simple app that can be run from the command line and just returns the version of the program.
There was a problem hiding this comment.
This indeed exists in src/pyobjcryst/pyobjcryst_app.py.
|
@sbillinge ready for review |
sbillinge
left a comment
There was a problem hiding this comment.
please see comment, the copyright statement is not quite right and needs to be updated everywhere.
|
|
||
| Copyright (c) 2014-2019, Brookhaven Science Associates, Brookhaven National Laboratory | ||
|
|
||
| Copyright (c) 2024-Present, The Trustees of Columbia University in the City of New York. |
There was a problem hiding this comment.
This doesn't seem right. I think it should be 2024-2025 here, then 2025-present pyobjcryst contributors. Please check that the statement is like this everywhere
No description provided.