Token: removed test-only stringifyList() overload#8411
Open
firewave wants to merge 1 commit intodanmar:mainfrom
Open
Token: removed test-only stringifyList() overload#8411firewave wants to merge 1 commit intodanmar:mainfrom
stringifyList() overload#8411firewave wants to merge 1 commit intodanmar:mainfrom
Conversation
several other tests also use the multi-parameter version
Collaborator
Author
|
Some of the stringify function could be made private as they are only used in the class or tests but that would require a way to expose private |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
several other tests already use the multi-parameter version