-
Notifications
You must be signed in to change notification settings - Fork 18
perf: cache release target jobs query #862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
80 changes: 80 additions & 0 deletions
80
apps/workspace-engine/pkg/store/releasetargets/get_jobs_for_release_target.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| package releasetargets | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "workspace-engine/pkg/oapi" | ||
|
|
||
| "workspace-engine/pkg/db" | ||
|
|
||
| "github.com/google/uuid" | ||
| gocache "github.com/patrickmn/go-cache" | ||
| "go.opentelemetry.io/otel/attribute" | ||
| ) | ||
|
|
||
| type GetJobsForReleaseTarget interface { | ||
| GetJobsForReleaseTarget( | ||
| ctx context.Context, | ||
| releaseTarget *oapi.ReleaseTarget, | ||
| ) map[string]*oapi.Job | ||
| } | ||
|
|
||
| var _ GetJobsForReleaseTarget = (*PostgresGetJobsForReleaseTarget)(nil) | ||
|
|
||
| type PostgresGetJobsForReleaseTarget struct { | ||
| cache *gocache.Cache | ||
| } | ||
|
|
||
| func NewGetJobsForReleaseTarget(opts ...Option) *PostgresGetJobsForReleaseTarget { | ||
| return &PostgresGetJobsForReleaseTarget{cache: buildCache(opts)} | ||
| } | ||
|
|
||
| func (s *PostgresGetJobsForReleaseTarget) GetJobsForReleaseTarget( | ||
| ctx context.Context, | ||
| releaseTarget *oapi.ReleaseTarget, | ||
| ) map[string]*oapi.Job { | ||
| ctx, span := tracer.Start(ctx, "Store.GetJobsForReleaseTarget") | ||
| defer span.End() | ||
|
|
||
| span.SetAttributes(attribute.String("release_target.deployment_id", releaseTarget.DeploymentId)) | ||
| span.SetAttributes(attribute.String("release_target.environment_id", releaseTarget.EnvironmentId)) | ||
| span.SetAttributes(attribute.String("release_target.resource_id", releaseTarget.ResourceId)) | ||
|
|
||
| if s.cache != nil { | ||
| if v, ok := s.cache.Get(releaseTarget.Key()); ok { | ||
| return v.(map[string]*oapi.Job) | ||
| } | ||
| } | ||
|
|
||
| deploymentID, err := uuid.Parse(releaseTarget.DeploymentId) | ||
| if err != nil { | ||
| return nil | ||
| } | ||
| environmentID, err := uuid.Parse(releaseTarget.EnvironmentId) | ||
| if err != nil { | ||
| return nil | ||
| } | ||
| resourceID, err := uuid.Parse(releaseTarget.ResourceId) | ||
| if err != nil { | ||
| return nil | ||
| } | ||
| rows, err := db.GetQueries(ctx).ListJobsByReleaseTarget(ctx, db.ListJobsByReleaseTargetParams{ | ||
| DeploymentID: deploymentID, | ||
| EnvironmentID: environmentID, | ||
| ResourceID: resourceID, | ||
| }) | ||
| if err != nil { | ||
| return nil | ||
| } | ||
|
|
||
| jobs := make(map[string]*oapi.Job, len(rows)) | ||
| for _, row := range rows { | ||
| jobs[row.ID.String()] = db.ToOapiJob(db.ListJobsByReleaseIDRow(row)) | ||
| } | ||
|
|
||
| if s.cache != nil { | ||
| s.cache.SetDefault(releaseTarget.Key(), jobs) | ||
| } | ||
|
|
||
| return jobs | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error paths are currently indistinguishable from “no jobs.”
Line 51, Line 55, Line 59, and Line 67 return
nilfor parse/DB failures, but the interface (Line 15-20) cannot surface errors. That makes transient failures look like empty results, which can mis-evaluate policy decisions.Proposed direction
type GetJobsForReleaseTarget interface { GetJobsForReleaseTarget( ctx context.Context, releaseTarget *oapi.ReleaseTarget, - ) map[string]*oapi.Job + ) (map[string]*oapi.Job, error) } func (s *PostgresGetJobsForReleaseTarget) GetJobsForReleaseTarget( ctx context.Context, releaseTarget *oapi.ReleaseTarget, -) map[string]*oapi.Job { +) (map[string]*oapi.Job, error) { ... deploymentID, err := uuid.Parse(releaseTarget.DeploymentId) if err != nil { - return nil + return nil, fmt.Errorf("parse deployment id: %w", err) } ... if err != nil { - return nil + return nil, fmt.Errorf("list jobs by release target: %w", err) } ... - return jobs + return jobs, nil }Also applies to: 49-68
🤖 Prompt for AI Agents